Prevent CHANGE_SLAB_TYPE from leaving room information on slabs #3422
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the CHANGE_SLAB_TYPE script command is used to change a room slab into another room slab, it would leave the old room present in the slab information.
Function
do_slab_efficiency_alteration
would do this:And find a room of type NULL, causing several log errors and related issues, possibly also player notifications when the room was destroyed.
This PR cleans that up.
To reproduce the original issue:
~
to see logging-> Notice a
!
message that says a room is destroyed, with the eye at pos (0,0).